Update Pull Request
Steps
- Identify the PR
List open PRs for current branch
gh pr list --head $(git branch --show-current)
Or get PR details by number
gh pr view <PR_NUMBER>
- Fetch Review Comments
View PR reviews and comments
gh pr view <PR_NUMBER> --comments
View the PR diff to understand context
gh pr diff <PR_NUMBER>
- Address Feedback
For each review comment:
-
Read and understand the feedback
-
Make the necessary code changes
-
Stage and commit with a descriptive message
Stage changes
git add -u
Commit with reference to what was addressed
git commit -m "address review: <brief description>"
- Push Updates
Push to the same branch (PR updates automatically)
git push
- Respond to Review Comments (Optional)
If you need to reply to specific comments:
Reply to a review comment
gh api repos/{owner}/{repo}/pulls/<PR_NUMBER>/comments/<COMMENT_ID>/replies
-f body="Done - updated the implementation as suggested"
Or use the GitHub web interface for complex discussions.
- Re-request Review (if needed)
Re-request review from specific reviewers
gh pr edit <PR_NUMBER> --add-reviewer <username>
Handling Common Review Requests
"Please add tests"
-
Identify the appropriate test file in packages/*/src/tests/
-
Add test cases covering the new functionality
-
Run pnpm test to verify
"Update types"
-
Check TypeScript errors with pnpm build
-
Update type definitions as needed
-
Ensure no type errors remain
"Fix lint issues"
pnpm format # Auto-fix formatting pnpm lint # Check and fix lint issues
"Update snapshots"
pnpm test:storybook:update git add packages/*/image_snapshots/ git commit -m "chore: update storybook snapshots"
Squashing Commits (if requested)
If the reviewer asks to squash commits:
Interactive rebase to squash
git rebase -i origin/main
In the editor, change 'pick' to 'squash' for commits to combine
Save and edit the combined commit message
Force push (safe for PR branches)
git push --force-with-lease
Example Workflow
1. Fetch latest review comments
gh pr view 42 --comments
2. Make changes based on feedback
... edit files ...
3. Commit and push
git add -u git commit -m "address review: add error handling for edge case" git push
4. Notify reviewer
echo "Updated PR #42 - addressed all review comments"